Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/fonts/OrientationIterator.h" 5 #include "platform/fonts/OrientationIterator.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 #include <string> 8 #include <string>
9 9
10 namespace blink { 10 namespace blink {
(...skipping 12 matching lines...) Expand all
23 : limit(theLimit), renderOrientation(theRenderOrientation) {} 23 : limit(theLimit), renderOrientation(theRenderOrientation) {}
24 }; 24 };
25 25
26 class OrientationIteratorTest : public testing::Test { 26 class OrientationIteratorTest : public testing::Test {
27 protected: 27 protected:
28 void CheckRuns(const Vector<TestRun>& runs) { 28 void CheckRuns(const Vector<TestRun>& runs) {
29 String text(emptyString16Bit()); 29 String text(emptyString16Bit());
30 Vector<ExpectedRun> expect; 30 Vector<ExpectedRun> expect;
31 for (auto& run : runs) { 31 for (auto& run : runs) {
32 text.append(String::fromUTF8(run.text.c_str())); 32 text.append(String::fromUTF8(run.text.c_str()));
33 expect.append(ExpectedRun(text.length(), run.code)); 33 expect.push_back(ExpectedRun(text.length(), run.code));
34 } 34 }
35 OrientationIterator orientationIterator(text.characters16(), text.length(), 35 OrientationIterator orientationIterator(text.characters16(), text.length(),
36 FontOrientation::VerticalMixed); 36 FontOrientation::VerticalMixed);
37 VerifyRuns(&orientationIterator, expect); 37 VerifyRuns(&orientationIterator, expect);
38 } 38 }
39 39
40 void VerifyRuns(OrientationIterator* orientationIterator, 40 void VerifyRuns(OrientationIterator* orientationIterator,
41 const Vector<ExpectedRun>& expect) { 41 const Vector<ExpectedRun>& expect) {
42 unsigned limit; 42 unsigned limit;
43 OrientationIterator::RenderOrientation renderOrientation; 43 OrientationIterator::RenderOrientation renderOrientation;
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 CHECK_RUNS({{"Abc", OrientationIterator::OrientationRotateSideways}, 154 CHECK_RUNS({{"Abc", OrientationIterator::OrientationRotateSideways},
155 {"ほへと", OrientationIterator::OrientationKeep}, 155 {"ほへと", OrientationIterator::OrientationKeep},
156 {"Xyz", OrientationIterator::OrientationRotateSideways}}); 156 {"Xyz", OrientationIterator::OrientationRotateSideways}});
157 } 157 }
158 158
159 TEST_F(OrientationIteratorTest, JapaneseMahjonggMixed) { 159 TEST_F(OrientationIteratorTest, JapaneseMahjonggMixed) {
160 CHECK_RUNS({{"いろはに🀤ほへと", OrientationIterator::OrientationKeep}}); 160 CHECK_RUNS({{"いろはに🀤ほへと", OrientationIterator::OrientationKeep}});
161 } 161 }
162 162
163 } // namespace blink 163 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/GlyphBuffer.h ('k') | third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698