third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp - Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)

Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/geometry/Region.cpp ('k') | third_party/WebKit/Source/platform/graphics/ContiguousContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp b/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp

index f9d51b5e148b8213f2c945679794c4b0be503f90..b38da5db5f585dfdef2c29ae8070a78eaaffd07f 100644

--- a/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp

@@ -125,7 +125,7 @@ void* ContiguousContainerBase::allocate(size_t objectSize,

}

void* element = bufferForAlloc->allocate(objectSize);

- m_elements.append(element);

+ m_elements.push_back(element);

return element;

}

@@ -172,7 +172,7 @@ ContiguousContainerBase::allocateNewBufferForNextAllocation(

std::unique_ptr<Buffer> newBuffer =

WTF::makeUnique<Buffer>(bufferSize, typeName);

Buffer* bufferToReturn = newBuffer.get();

- m_buffers.append(std::move(newBuffer));

+ m_buffers.push_back(std::move(newBuffer));

m_endIndex = m_buffers.size() - 1;

return bufferToReturn;

}