DescriptionChanged WritingMode to an enum class and renamed its members
Changed WritingMode to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent (although these names are not as self-documenting as they
were previously, so pre-work in crrev.com/2595833002 replaced as many
callsites as possible with helper functions with more descriptive
names).
Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)
This is also pre-work to allow WritingMode to be used by generated
fields in ComputedStyleBase.
BUG=628043
Committed: https://crrev.com/983b113dc5903d650ca0804e35caffb79f003d0e
Cr-Commit-Position: refs/heads/master@{#440343}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Added comment #Depends on Patchset: Messages
Total messages: 21 (10 generated)
|