Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)

Created:
3 years, 12 months ago by sashab
Modified:
3 years, 12 months ago
CC:
ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, cbiesinger, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), glebl+reviews_chromium.org, jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, ojan+watch_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed WritingMode to an enum class and renamed its members Changed WritingMode to an enum class and gave it an unsigned underlying type. Also renamed its members to match the CSS keywords they represent (although these names are not as self-documenting as they were previously, so pre-work in crrev.com/2595833002 replaced as many callsites as possible with helper functions with more descriptive names). Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to allow WritingMode to be used by generated fields in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/983b113dc5903d650ca0804e35caffb79f003d0e Cr-Commit-Position: refs/heads/master@{#440343}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -82 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/LengthBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/text/WritingMode.h View 1 1 chunk +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (10 generated)
sashab
3 years, 12 months ago (2016-12-22 02:14:19 UTC) #2
aazzam
lgtm :) https://codereview.chromium.org/2591373003/diff/1/third_party/WebKit/Source/platform/text/WritingMode.h File third_party/WebKit/Source/platform/text/WritingMode.h (right): https://codereview.chromium.org/2591373003/diff/1/third_party/WebKit/Source/platform/text/WritingMode.h#newcode36 third_party/WebKit/Source/platform/text/WritingMode.h:36: enum class WritingMode : unsigned { HorizontalTb, ...
3 years, 12 months ago (2016-12-22 02:18:23 UTC) #3
sashab
Ty anna!! PTAL at the new comment and let me know what you think Alan ...
3 years, 12 months ago (2016-12-22 02:35:27 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 12 months ago (2016-12-22 03:18:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591373003/20001
3 years, 12 months ago (2016-12-22 03:19:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/331344)
3 years, 12 months ago (2016-12-22 03:29:17 UTC) #11
sashab
haraken@ platform/ rs please :)
3 years, 12 months ago (2016-12-22 03:30:14 UTC) #13
haraken
LGTM
3 years, 12 months ago (2016-12-22 04:04:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591373003/20001
3 years, 12 months ago (2016-12-22 04:16:15 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-22 05:05:01 UTC) #19
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 05:09:58 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/983b113dc5903d650ca0804e35caffb79f003d0e
Cr-Commit-Position: refs/heads/master@{#440343}

Powered by Google App Engine
This is Rietveld 408576698