Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)
Patch Set: Added comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
index 07b85d06d2497e256ce2d09379774135f17190d9..20d7cde898f31fb54a84bdf3dde6cb3903cf3602 100644
--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
@@ -611,23 +611,23 @@ LayoutFlexibleBox::getTransformedWritingMode() const {
WritingMode mode = style()->getWritingMode();
if (!isColumnFlow()) {
static_assert(
- static_cast<TransformedWritingMode>(TopToBottomWritingMode) ==
+ static_cast<TransformedWritingMode>(WritingMode::HorizontalTb) ==
TransformedWritingMode::TopToBottomWritingMode &&
- static_cast<TransformedWritingMode>(LeftToRightWritingMode) ==
+ static_cast<TransformedWritingMode>(WritingMode::VerticalLr) ==
TransformedWritingMode::LeftToRightWritingMode &&
- static_cast<TransformedWritingMode>(RightToLeftWritingMode) ==
+ static_cast<TransformedWritingMode>(WritingMode::VerticalRl) ==
TransformedWritingMode::RightToLeftWritingMode,
"WritingMode and TransformedWritingMode must match values.");
return static_cast<TransformedWritingMode>(mode);
}
switch (mode) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
return style()->isLeftToRightDirection()
? TransformedWritingMode::LeftToRightWritingMode
: TransformedWritingMode::RightToLeftWritingMode;
- case LeftToRightWritingMode:
- case RightToLeftWritingMode:
+ case WritingMode::VerticalLr:
+ case WritingMode::VerticalRl:
return style()->isLeftToRightDirection()
? TransformedWritingMode::TopToBottomWritingMode
: TransformedWritingMode::BottomToTopWritingMode;

Powered by Google App Engine
This is Rietveld 408576698