third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc - Issue 2591373003: Changed WritingMode to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)

Patch Set: Added comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc b/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

index 9dab4222ec5fa25257e1ed0f03a346d9d94182d0..8a9fef34158e9d3671a02d9069193ca5cec2ef08 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

@@ -10,11 +10,11 @@ namespace blink {

NGWritingMode FromPlatformWritingMode(WritingMode mode) {

switch (mode) {

- case TopToBottomWritingMode:

+ case WritingMode::HorizontalTb:

return kHorizontalTopBottom;

- case RightToLeftWritingMode:

+ case WritingMode::VerticalRl:

return kVerticalRightLeft;

- case LeftToRightWritingMode:

+ case WritingMode::VerticalLr:

return kVerticalLeftRight;

default:

NOTREACHED();