Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)
Patch Set: Added comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 7956a9a230ff321d91cdf015ad20bccba67a7b9d..4a9d096ae65bf4a23957dff1751e29ee6239ab24 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -2880,13 +2880,13 @@ template <>
inline CSSIdentifierValue::CSSIdentifierValue(WritingMode e)
: CSSValue(IdentifierClass) {
switch (e) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
m_valueID = CSSValueHorizontalTb;
break;
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
m_valueID = CSSValueVerticalRl;
break;
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
m_valueID = CSSValueVerticalLr;
break;
}
@@ -2900,19 +2900,19 @@ inline WritingMode CSSIdentifierValue::convertTo() const {
case CSSValueLrTb:
case CSSValueRl:
case CSSValueRlTb:
- return TopToBottomWritingMode;
+ return WritingMode::HorizontalTb;
case CSSValueVerticalRl:
case CSSValueTb:
case CSSValueTbRl:
- return RightToLeftWritingMode;
+ return WritingMode::VerticalRl;
case CSSValueVerticalLr:
- return LeftToRightWritingMode;
+ return WritingMode::VerticalLr;
default:
break;
}
ASSERT_NOT_REACHED();
- return TopToBottomWritingMode;
+ return WritingMode::HorizontalTb;
}
template <>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698