third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2591373003: Changed WritingMode to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)

Patch Set: Added comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index 37499446187cc4792c43141e13e1d0dc6b406d24..df0aee4d5142d4df60d09be2e72f04c77e05688f 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -120,13 +120,13 @@ TEST_F(NGBlockLayoutAlgorithmTest, LayoutBlockChildrenWithWritingMode) {

const int kMarginLeft = 100;

RefPtr<ComputedStyle> div1_style = ComputedStyle::create();

- div1_style->setWritingMode(LeftToRightWritingMode);

+ div1_style->setWritingMode(WritingMode::VerticalLr);

NGBlockNode* div1 = new NGBlockNode(div1_style.get());

RefPtr<ComputedStyle> div2_style = ComputedStyle::create();

div2_style->setHeight(Length(kHeight, Fixed));

div2_style->setWidth(Length(kWidth, Fixed));

- div1_style->setWritingMode(TopToBottomWritingMode);

+ div1_style->setWritingMode(WritingMode::HorizontalTb);

div2_style->setMarginLeft(Length(kMarginLeft, Fixed));

NGBlockNode* div2 = new NGBlockNode(div2_style.get());

@@ -393,7 +393,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, CollapsingMarginsCase5) {

style_->setWidth(Length(500, Fixed));

style_->setHeight(Length(500, Fixed));

- style_->setWritingMode(LeftToRightWritingMode);

+ style_->setWritingMode(WritingMode::VerticalLr);

// Vertical DIV

RefPtr<ComputedStyle> vertical_style = ComputedStyle::create();

@@ -404,7 +404,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, CollapsingMarginsCase5) {

// Horizontal DIV

RefPtr<ComputedStyle> horizontal_style = ComputedStyle::create();

horizontal_style->setMarginLeft(Length(kHorizontalDivMarginLeft, Fixed));

- horizontal_style->setWritingMode(TopToBottomWritingMode);

+ horizontal_style->setWritingMode(WritingMode::HorizontalTb);

NGBlockNode* horizontal_div = new NGBlockNode(horizontal_style.get());

vertical_div->SetNextSibling(horizontal_div);

@@ -448,7 +448,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, CollapsingMarginsCase6) {

RefPtr<ComputedStyle> div1_style = ComputedStyle::create();

div1_style->setWidth(Length(kWidth, Fixed));

div1_style->setHeight(Length(kHeight, Fixed));

- div1_style->setWritingMode(RightToLeftWritingMode);

+ div1_style->setWritingMode(WritingMode::VerticalRl);

div1_style->setMarginBottom(Length(kMarginBottom, Fixed));

NGBlockNode* div1 = new NGBlockNode(div1_style.get());