third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc - Issue 2591373003: Changed WritingMode to an enum class and renamed its members

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)

Patch Set: Added comment Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/layout/ng/ng_writing_mode.h"	5 #include "core/layout/ng/ng_writing_mode.h"

6	6

7 #include "wtf/Assertions.h"	7 #include "wtf/Assertions.h"

8	8

9 namespace blink {	9 namespace blink {

10	10

11 NGWritingMode FromPlatformWritingMode(WritingMode mode) {	11 NGWritingMode FromPlatformWritingMode(WritingMode mode) {

12 switch (mode) {	12 switch (mode) {

13 case TopToBottomWritingMode:	13 case WritingMode::HorizontalTb:

14 return kHorizontalTopBottom;	14 return kHorizontalTopBottom;

15 case RightToLeftWritingMode:	15 case WritingMode::VerticalRl:

16 return kVerticalRightLeft;	16 return kVerticalRightLeft;

17 case LeftToRightWritingMode:	17 case WritingMode::VerticalLr:

18 return kVerticalLeftRight;	18 return kVerticalLeftRight;

19 default:	19 default:

20 NOTREACHED();	20 NOTREACHED();

21 return kHorizontalTopBottom;	21 return kHorizontalTopBottom;

22 }	22 }

23 }	23 }

24	24

25 } // namespace blink	25 } // namespace blink

OLD	NEW