Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)
Patch Set: Added comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 070c725a0c9e87d02d45c3e2a7c9ac80c7f56136..c4ac7c287c2a177c7092a987ac06a1786bac00c3 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -2170,11 +2170,11 @@ Color ComputedStyle::visitedDependentColor(int colorProperty) const {
const BorderValue& ComputedStyle::borderBefore() const {
switch (getWritingMode()) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
return borderTop();
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
return borderLeft();
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
return borderRight();
}
ASSERT_NOT_REACHED();
@@ -2183,11 +2183,11 @@ const BorderValue& ComputedStyle::borderBefore() const {
const BorderValue& ComputedStyle::borderAfter() const {
switch (getWritingMode()) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
return borderBottom();
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
return borderRight();
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
return borderLeft();
}
ASSERT_NOT_REACHED();
@@ -2208,11 +2208,11 @@ const BorderValue& ComputedStyle::borderEnd() const {
int ComputedStyle::borderBeforeWidth() const {
switch (getWritingMode()) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
return borderTopWidth();
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
return borderLeftWidth();
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
return borderRightWidth();
}
ASSERT_NOT_REACHED();
@@ -2221,11 +2221,11 @@ int ComputedStyle::borderBeforeWidth() const {
int ComputedStyle::borderAfterWidth() const {
switch (getWritingMode()) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
return borderBottomWidth();
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
return borderRightWidth();
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
return borderLeftWidth();
}
ASSERT_NOT_REACHED();
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/platform/LengthBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698