Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)
Patch Set: Added comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
index 55275ee134c7d43f63a6c7935fd88720d255bf87..282d8382e8e4b3b33cde487b3c7c1868cf749988 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
@@ -363,10 +363,10 @@ static void adjustStyleForDisplay(ComputedStyle& style,
// FIXME: Since we don't support block-flow on flexible boxes yet, disallow
// setting of block-flow to anything other than TopToBottomWritingMode.
// https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support.
- if (style.getWritingMode() != TopToBottomWritingMode &&
+ if (style.getWritingMode() != WritingMode::HorizontalTb &&
(style.display() == EDisplay::WebkitBox ||
style.display() == EDisplay::WebkitInlineBox))
- style.setWritingMode(TopToBottomWritingMode);
+ style.setWritingMode(WritingMode::HorizontalTb);
if (parentStyle.isDisplayFlexibleOrGridBox()) {
style.setFloating(EFloat::None);

Powered by Google App Engine
This is Rietveld 408576698