Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)

Created:
4 years ago by jiahuiguo
Modified:
3 years, 11 months ago
CC:
Jared Saul, chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace hard-coded colors from ui::NativeTheme for consistency and accessibility, and refactor to let views, not controllers in control of presentation details, while the controller returns a color id instead of a color. BUG=666523 TEST=Smoke Test Review-Url: https://codereview.chromium.org/2581513002 Cr-Commit-Position: refs/heads/master@{#442384} Committed: https://chromium.googlesource.com/chromium/src/+/d9f57d21417b53ef91e922a63204d950010d0251

Patch Set 1 #

Total comments: 8

Patch Set 2 : Refactor callsites for colors #

Patch Set 3 : Delete unused popup_constants.h includes #

Total comments: 14

Patch Set 4 : Tweak docs, add TODOs and modify OSX function call #

Patch Set 5 : Using NativeThemeMac::instance() in OSX platform #

Patch Set 6 : Using NativeTheme::GetInstanceForNativeUi() to get NativeThemeMac instance #

Total comments: 6

Patch Set 7 : Format comments and TODOs, and fix typos #

Patch Set 8 : Resolved conflicts during patching #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -43 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller.h View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_layout_model.h View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_layout_model.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/popup_constants.h View 1 2 3 4 5 6 1 chunk +1 line, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm View 1 2 3 4 5 6 7 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view.cc View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_view_views.cc View 1 2 3 4 5 6 6 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 77 (60 generated)
Mathieu
Hi Jason, I'm thinking we should align with the omnibox here which uses kColorId_ResultsTable*, what ...
4 years ago (2016-12-15 17:37:06 UTC) #16
Evan Stade
https://codereview.chromium.org/2581513002/diff/1/chrome/browser/ui/autofill/popup_constants.h File chrome/browser/ui/autofill/popup_constants.h (right): https://codereview.chromium.org/2581513002/diff/1/chrome/browser/ui/autofill/popup_constants.h#newcode21 chrome/browser/ui/autofill/popup_constants.h:21: ui::NativeTheme::GetInstanceForNativeUi()->GetSystemColor( you shouldn't really be calling this here as ...
4 years ago (2016-12-15 17:42:15 UTC) #18
jiahuiguo
Hi Mathieu and Evan, Please review a changelist from jiahuiguo. https://codereview.chromium.org/2581513002/diff/1/chrome/browser/ui/autofill/popup_constants.h File chrome/browser/ui/autofill/popup_constants.h (right): https://codereview.chromium.org/2581513002/diff/1/chrome/browser/ui/autofill/popup_constants.h#newcode21 ...
4 years ago (2016-12-20 09:58:11 UTC) #26
Evan Stade
this is great. Finally a second client for the ResultsTable colors!! lgtm with minor nits ...
4 years ago (2016-12-20 18:01:19 UTC) #27
Mathieu
Thanks, lgtm with nits https://codereview.chromium.org/2581513002/diff/40001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc File chrome/browser/ui/views/autofill/autofill_popup_base_view.cc (right): https://codereview.chromium.org/2581513002/diff/40001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc#newcode67 chrome/browser/ui/views/autofill/autofill_popup_base_view.cc:67: ui::NativeTheme::kColorId_UnfocusedBorderColor))); Is there a possibility ...
4 years ago (2016-12-20 20:36:40 UTC) #28
jiahuiguo
Hi Mathieu and Evan, Thanks for the comments, PTAL. https://codereview.chromium.org/2581513002/diff/40001/chrome/browser/ui/autofill/autofill_popup_layout_model.h File chrome/browser/ui/autofill/autofill_popup_layout_model.h (right): https://codereview.chromium.org/2581513002/diff/40001/chrome/browser/ui/autofill/autofill_popup_layout_model.h#newcode78 chrome/browser/ui/autofill/autofill_popup_layout_model.h:78: ...
3 years, 11 months ago (2017-01-03 19:37:52 UTC) #41
Mathieu
lgtm with nits to reference the bugs in the code. Feel free to submit when ...
3 years, 11 months ago (2017-01-04 13:51:48 UTC) #42
Jared Saul
Just some nits https://codereview.chromium.org/2581513002/diff/100001/chrome/browser/ui/autofill/autofill_popup_controller.h File chrome/browser/ui/autofill/autofill_popup_controller.h (right): https://codereview.chromium.org/2581513002/diff/100001/chrome/browser/ui/autofill/autofill_popup_controller.h#newcode51 chrome/browser/ui/autofill/autofill_popup_controller.h:51: // or default popup background should ...
3 years, 11 months ago (2017-01-04 19:51:38 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581513002/120001
3 years, 11 months ago (2017-01-05 19:03:12 UTC) #50
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/335685)
3 years, 11 months ago (2017-01-05 19:10:21 UTC) #52
jiahuiguo
Hi Rachel, Can you help review the change in file chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm? Thanks, https://codereview.chromium.org/2581513002/diff/40001/chrome/browser/ui/autofill/popup_constants.h File chrome/browser/ui/autofill/popup_constants.h ...
3 years, 11 months ago (2017-01-05 19:21:20 UTC) #55
Mathieu
+Robert for Mac
3 years, 11 months ago (2017-01-07 01:15:05 UTC) #58
Robert Sesek
lgtm
3 years, 11 months ago (2017-01-09 19:53:35 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581513002/120001
3 years, 11 months ago (2017-01-09 20:01:38 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/132380) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-09 20:05:59 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581513002/140001
3 years, 11 months ago (2017-01-09 22:35:41 UTC) #74
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:47:38 UTC) #77
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/d9f57d21417b53ef91e922a63204...

Powered by Google App Engine
This is Rietveld 408576698