Replace hard-coded colors from ui::NativeTheme for consistency and accessibility.

chrome/browser/ui/autofill/popup_constants.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_
 #define CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_
 
 #include "third_party/skia/include/core/SkColor.h"
+#include "ui/native_theme/native_theme.h"
 
 namespace autofill {
 
 // The size of the border around the entire results popup, in pixels.
 const int kPopupBorderThickness = 1;
 
 // Various colors used in the Autofill popup.
-// TODO(crbug.com/666523): These colors ought to be replaced by getting colors
-// from ui::NativeTheme for consistency and accessibility.
-const SkColor kBorderColor = SkColorSetRGB(0xC7, 0xCA, 0xCE);
-const SkColor kHoveredBackgroundColor = SkColorSetRGB(0xCD, 0xCD, 0xCD);
-const SkColor kLabelTextColor = SkColorSetRGB(0x64, 0x64, 0x64);
+const SkColor kBorderColor =
+    ui::NativeTheme::GetInstanceForNativeUi()->GetSystemColor(
+        ui::NativeTheme::kColorId_UnfocusedBorderColor);
+const SkColor kHoveredBackgroundColor =
+    ui::NativeTheme::GetInstanceForNativeUi()->GetSystemColor(

[Evan Stade, 2016/12/15 17:42:14]

you shouldn't really be calling this here as it won't always return the correct
native theme, and besides that you're creating new static initializers.

The way this code is structured makes this harder to do right (i.e. views, not
controllers, should be in control of presentation details like the exact color
used to represent hovering). You'll need to change callsites so that the
controller returns a color id instead of a color, and the view can do
GetNativeTheme()->GetSystemColor(returned_id);

[jiahuiguo, 2016/12/20 09:58:10]

Done.

+        ui::NativeTheme::kColorId_ResultsTableHoveredBackground);
+const SkColor kLabelTextColor =
+    ui::NativeTheme::GetInstanceForNativeUi()->GetSystemColor(
+        ui::NativeTheme::kColorId_TextfieldReadOnlyColor);

[Mathieu, 2016/12/15 17:37:06]

Should we use kColorId_ResultsTableNormalDimmedText?

[jiahuiguo, 2016/12/20 09:58:10]

Done.

 constexpr SkColor kPopupBackground = SK_ColorWHITE;

[Mathieu, 2016/12/15 17:37:06]

Should we use kColorId_ResultsTableNormalBackground? 

[jiahuiguo, 2016/12/20 09:58:11]

Done.

 constexpr SkColor kValueTextColor = SK_ColorBLACK;

[Mathieu, 2016/12/15 17:37:06]

Should we use kColorId_ResultsTableNormalText?

[jiahuiguo, 2016/12/20 09:58:11]

Done.

 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_