Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller.h

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)
Patch Set: Resolved conflicts during patching Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_popup_controller_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_popup_controller.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller.h b/chrome/browser/ui/autofill/autofill_popup_controller.h
index 5bede9c60c457b724225c0637a4eeb994d33e13b..c9aec43f61bde65157c3d88dd5d74b8f0c8a022a 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller.h
@@ -14,6 +14,7 @@
#include "build/build_config.h"
#include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h"
#include "third_party/skia/include/core/SkColor.h"
+#include "ui/native_theme/native_theme.h"
namespace autofill {
@@ -46,9 +47,10 @@ class AutofillPopupController : public AutofillPopupViewDelegate {
// Removes the suggestion at the given index.
virtual bool RemoveSuggestion(int index) = 0;
- // Returns the background color of the row item according to its |index|, or
- // transparent if the default popup background should be used.
- virtual SkColor GetBackgroundColorForRow(int index) const = 0;
+ // Returns the background color ID of the row item according to its |index|,
+ // or default popup background otherwise.
+ virtual ui::NativeTheme::ColorId GetBackgroundColorIDForRow(
+ int index) const = 0;
// Returns the index of the selected line. A line is "selected" when it is
// hovered or has keyboard focus.
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_popup_controller_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698