Replace hard-coded colors from ui::NativeTheme for consistency and accessibility.

chrome/browser/ui/autofill/popup_constants.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_
 #define CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_
 
-#include "third_party/skia/include/core/SkColor.h"
-
 namespace autofill {
 
 // The size of the border around the entire results popup, in pixels.

[Evan Stade, 2016/12/20 18:01:19]

looks like this is actually in dip, not pixels, i.e. for a retina display
(--force-device-scale-factor=2) it would be 2px. That said, it probably /should/
be 1 pixel as most strokes these days are 1px not 1 dip.

tl;dr: please update the docs to match reality (dip) and consider changing
reality to 1px in the future. (see location_bar/background_with_1px_border for
an example)

[jiahuiguo, 2017/01/03 19:37:52]

Changed the doc and filed a bug for changing to 1px here:
https://crbug.com/676221

[Mathieu, 2017/01/04 13:51:48]

Can you reference the bug here like so:

TODO(crbug.com/676221): Change this to pixels.

[jiahuiguo, 2017/01/05 19:21:20]

Done.

 const int kPopupBorderThickness = 1;
 
-// Various colors used in the Autofill popup.
-// TODO(crbug.com/666523): These colors ought to be replaced by getting colors
-// from ui::NativeTheme for consistency and accessibility.
-const SkColor kBorderColor = SkColorSetRGB(0xC7, 0xCA, 0xCE);
-const SkColor kHoveredBackgroundColor = SkColorSetRGB(0xCD, 0xCD, 0xCD);
-const SkColor kLabelTextColor = SkColorSetRGB(0x64, 0x64, 0x64);
-constexpr SkColor kPopupBackground = SK_ColorWHITE;
-constexpr SkColor kValueTextColor = SK_ColorBLACK;
-
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_