Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4808)

Unified Diff: chrome/browser/ui/autofill/popup_constants.h

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)
Patch Set: Resolved conflicts during patching Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/popup_constants.h
diff --git a/chrome/browser/ui/autofill/popup_constants.h b/chrome/browser/ui/autofill/popup_constants.h
index 30c1dfc7759425d8dfab5dd478a48e409ba69ded..ca3a74a24c081eb557ba46bd3cc667785b6d67ce 100644
--- a/chrome/browser/ui/autofill/popup_constants.h
+++ b/chrome/browser/ui/autofill/popup_constants.h
@@ -5,22 +5,11 @@
#ifndef CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_
#define CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_
-#include "third_party/skia/include/core/SkColor.h"
-
namespace autofill {
-// The size of the border around the entire results popup, in pixels.
+// TODO(crbug.com/676221): Change this to pixels
const int kPopupBorderThickness = 1;
-// Various colors used in the Autofill popup.
-// TODO(crbug.com/666523): These colors ought to be replaced by getting colors
-// from ui::NativeTheme for consistency and accessibility.
-const SkColor kBorderColor = SkColorSetRGB(0xC7, 0xCA, 0xCE);
-const SkColor kHoveredBackgroundColor = SkColorSetRGB(0xCD, 0xCD, 0xCD);
-const SkColor kLabelTextColor = SkColorSetRGB(0x64, 0x64, 0x64);
-constexpr SkColor kPopupBackground = SK_ColorWHITE;
-constexpr SkColor kValueTextColor = SK_ColorBLACK;
-
} // namespace autofill
#endif // CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_

Powered by Google App Engine
This is Rietveld 408576698