Replace hard-coded colors from ui::NativeTheme for consistency and accessibility.

chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_popup_base_view.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/autofill/popup_constants.h"
+#include "ui/native_theme/native_theme.h"
 #include "ui/views/border.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/widget/widget.h"
 
 namespace autofill {
 
 AutofillPopupBaseView::AutofillPopupBaseView(
     AutofillPopupViewDelegate* delegate,
     views::Widget* parent_widget)
     : delegate_(delegate),
@@ skipping 30 matching lines @@
     params.delegate = this;
     params.parent = parent_widget_->GetNativeView();
     widget->Init(params);
 
     // No animation for popup appearance (too distracting).
     widget->SetVisibilityAnimationTransition(views::Widget::ANIMATE_HIDE);
 
     show_time_ = base::Time::Now();
   }
 
-  SetBorder(views::CreateSolidBorder(kPopupBorderThickness, kBorderColor));
+  SetBorder(views::CreateSolidBorder(
+      kPopupBorderThickness,
+      GetNativeTheme()->GetSystemColor(
+          ui::NativeTheme::kColorId_UnfocusedBorderColor)));

[Mathieu, 2016/12/20 20:36:40]

Is there a possibility to have a code path where we are using
kColorId_FocusedBorderColor when hovered? Feel free to add as
TODO(crbug.com/xxxxxx) 

https://cs.chromium.org/chromium/src/ui/native_theme/native_theme.h?rcl=0&l=260

[jiahuiguo, 2017/01/03 19:37:52]

Done. Added in https://crbug.com/676164

[Mathieu, 2017/01/04 13:51:48]

Please reference here:

// TODO(crbug.com/676164): ...

[jiahuiguo, 2017/01/05 19:21:20]

Done.

 
   DoUpdateBoundsAndRedrawPopup();
   GetWidget()->Show();
 
   // Showing the widget can change native focus (which would result in an
   // immediate hiding of the popup). Only start observing after shown.
   if (initialize_widget)
     views::WidgetFocusManager::GetInstance()->AddFocusChangeListener(this);
 }
 
@@ skipping 156 matching lines @@
 void AutofillPopupBaseView::HideController() {
   if (delegate_)
     delegate_->Hide();
 }
 
 gfx::NativeView AutofillPopupBaseView::container_view() {
   return delegate_->container_view();
 }
 
 }  // namespace autofill