chrome/browser/ui/autofill/popup_constants.h - Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/autofill/popup_constants.h

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)

Patch Set: Using NativeTheme::GetInstanceForNativeUi() to get NativeThemeMac instance Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/autofill/autofill_popup_layout_model.h ('K') | « chrome/browser/ui/autofill/autofill_popup_layout_model.cc ('k') | chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_	5 #ifndef CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_

6 #define CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_	6 #define CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_

7	7

8 #include "third_party/skia/include/core/SkColor.h"

9

10 namespace autofill {	8 namespace autofill {

11	9

12 // The size of the border around the entire results popup, in pixels.	10 // TODO(crbug.com/676221): Changing the border size from dip to px
	Jared Saul 2017/01/04 19:51:38 s/Changing/Change s/Changing/Change jiahuiguo 2017/01/05 19:21:20 Done. Show quoted text On 2017/01/04 19:51:38, jsaul wrote: > s/Changing/Change Done.
	11 // The size of the border around the entire results popup, in dip.

13 const int kPopupBorderThickness = 1;	12 const int kPopupBorderThickness = 1;

14	13

15 // Various colors used in the Autofill popup.

16 // TODO(crbug.com/666523): These colors ought to be replaced by getting colors

17 // from ui::NativeTheme for consistency and accessibility.

18 const SkColor kBorderColor = SkColorSetRGB(0xC7, 0xCA, 0xCE);

19 const SkColor kHoveredBackgroundColor = SkColorSetRGB(0xCD, 0xCD, 0xCD);

20 const SkColor kLabelTextColor = SkColorSetRGB(0x64, 0x64, 0x64);

21 constexpr SkColor kPopupBackground = SK_ColorWHITE;

22 constexpr SkColor kValueTextColor = SK_ColorBLACK;

23

24 } // namespace autofill	14 } // namespace autofill

25	15

26 #endif // CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_	16 #endif // CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_

OLD	NEW