Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3936)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)
Patch Set: Resolved conflicts during patching Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index a7a3ebf2d38bf0701efdafcbe07bc8408c9ff1d9..0b4ac8810a0b21a1bf236150a33de3b59e9640c4 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -13,7 +13,6 @@
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/ui/autofill/autofill_popup_view.h"
-#include "chrome/browser/ui/autofill/popup_constants.h"
#include "components/autofill/core/browser/autofill_popup_delegate.h"
#include "components/autofill/core/browser/popup_item_ids.h"
#include "components/autofill/core/browser/suggestion.h"
@@ -375,11 +374,11 @@ bool AutofillPopupControllerImpl::RemoveSuggestion(int list_index) {
return true;
}
-SkColor AutofillPopupControllerImpl::GetBackgroundColorForRow(int index) const {
- if (index == selected_line_)
- return kHoveredBackgroundColor;
-
- return SK_ColorTRANSPARENT;
+ui::NativeTheme::ColorId
+AutofillPopupControllerImpl::GetBackgroundColorIDForRow(int index) const {
+ return index == selected_line_ ?
+ ui::NativeTheme::kColorId_ResultsTableHoveredBackground :
+ ui::NativeTheme::kColorId_ResultsTableNormalBackground;
}
int AutofillPopupControllerImpl::selected_line() const {
« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_impl.h ('k') | chrome/browser/ui/autofill/autofill_popup_layout_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698