|
|
Style change: Rename error variables "e" -> "error"
Reason: Pylint warns about single-character variable names (outside of list comprehension expressions etc) for a couple of reasons; they are sometimes not clear or descriptive, and they may be harder to search/replace.
While it may make sense to make an exception for `e` as an error name in except clauses, it's more consistent to make it a general rule that variable names should be more than one character.
This CL also removes redundant conversions to str when formatting, e.g.
'<%s>' % str(e) ==> '<%s>' % e
BUG= 643937
Committed: https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8
Cr-Commit-Position: refs/heads/master@{#440548}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+105 lines, -102 lines) |
Patch |
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/common/memoized_unittest.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py
|
View
|
1
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/formatter/main_unittest.py
|
View
|
1
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
|
View
|
|
5 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
|
View
|
1
|
3 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
|
View
|
|
2 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
|
View
|
|
2 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
|
View
|
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
|
View
|
1
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
Total messages: 20 (15 generated)
|