Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py

Issue 2580293002: Style change: Rename error variables "e" -> "error" (Closed)
Patch Set: Rebase and fix formatter unittest. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py
index 5293ccb16b9345041b152677f33af0ffc10956c2..e6e53a8d52887222f1b980fde6c3dede6440d2a2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py
@@ -73,10 +73,10 @@ class PrettyDiff(Command):
# We return the pretty_diff_file here because we need to keep the
# file alive until the user has had a chance to confirm the diff.
return pretty_diff_file
- except ScriptError as e:
+ except ScriptError as error:
_log.warning("PrettyPatch failed. :(")
- _log.error(e.message_with_output())
- self._exit(e.exit_code or 2)
+ _log.error(error.message_with_output())
+ self._exit(error.exit_code or 2)
except OSError:
_log.warning("PrettyPatch unavailable.")
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698