third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py - Issue 2580293002: Style change: Rename error variables "e" -> "error"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

Issue 2580293002: Style change: Rename error variables "e" -> "error" (Closed)

Patch Set: Rebase and fix formatter unittest. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

index d3ae88c124e3ec3fe0a14d7b5becb28e6fbf067c..d20742807890317f984125668ffd6950a8073fe6 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

@@ -63,9 +63,9 @@ def lint(host, options):

test_expectations.TestExpectations(port_to_lint,

expectations_dict={expectations_file: expectations_dict[expectations_file]},

is_lint_mode=True)

- except test_expectations.ParseError as e:

+ except test_expectations.ParseError as error:

_log.error('')

- for warning in e.warnings:

+ for warning in error.warnings:

_log.error(warning)

failures.append('%s: %s' % (expectations_file, warning))

_log.error('')

@@ -143,8 +143,8 @@ def main(argv, _, stderr):

exit_status = run_checks(host, options, stderr)

except KeyboardInterrupt:

exit_status = INTERRUPTED_EXIT_STATUS

- except Exception as e:

- print >> stderr, '\n%s raised: %s' % (e.__class__.__name__, str(e))

+ except Exception as error: # pylint: disable=broad-except

+ print >> stderr, '\n%s raised: %s' % (error.__class__.__name__, error)

traceback.print_exc(file=stderr)

exit_status = EXCEPTIONAL_EXIT_STATUS