Style change: Rename error variables "e" -> "error"

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 13 matching lines @@
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 """Windows implementation of the Port interface."""
 
 import errno
 import logging
 
+# The _winreg library is only available on Windows.
+# https://docs.python.org/2/library/_winreg.html
 try:
-    import _winreg
-except ImportError as e:
-    _winreg = None
-    WindowsError = Exception  # this shuts up pylint.
+    import _winreg  # pylint: disable=import-error
+except ImportError:
+    _winreg = None  # pylint: disable=invalid-name
 
 from webkitpy.layout_tests.breakpad.dump_reader_win import DumpReaderWin
 from webkitpy.layout_tests.models import test_run_results
 from webkitpy.layout_tests.port import base
 from webkitpy.layout_tests.servers import crash_service
 
 
 _log = logging.getLogger(__name__)
 
 
@@ skipping 64 matching lines @@
             # overriding the former), so reading from HKCR ensures that we get
             # the value if it is set in either place. See als comments below.
             hkey = _winreg.OpenKey(_winreg.HKEY_CLASSES_ROOT, sub_key)
             args = _winreg.QueryValue(hkey, '').split()
             _winreg.CloseKey(hkey)
 
             # In order to keep multiple checkouts from stepping on each other, we simply check that an
             # existing entry points to a valid path and has the right command line.
             if len(args) == 2 and self._filesystem.exists(args[0]) and args[0].endswith('perl.exe') and args[1] == '-wT':
                 return True
-        except WindowsError as e:
-            if e.errno != errno.ENOENT:
-                raise e
+        except WindowsError as error:  # WindowsError is not defined on non-Windows platforms - pylint: disable=undefined-variable
+            if error.errno != errno.ENOENT:
+                raise
             # The key simply probably doesn't exist.
 
         # Note that we write to HKCU so that we don't need privileged access
         # to the registry, and that will get reflected in HKCR when it is read, above.
         cmdline = self.path_from_chromium_base('third_party', 'perl', 'perl', 'bin', 'perl.exe') + ' -wT'
         hkey = _winreg.CreateKeyEx(_winreg.HKEY_CURRENT_USER, 'Software\\Classes\\' + sub_key, 0, _winreg.KEY_WRITE)
         _winreg.SetValue(hkey, '', _winreg.REG_SZ, cmdline)
         _winreg.CloseKey(hkey)
         return True
 
@@ skipping 106 matching lines @@
         return result
 
     def look_for_new_crash_logs(self, crashed_processes, start_time):
         if self.get_option('disable_breakpad'):
             return None
         return self._dump_reader.look_for_new_crash_logs(crashed_processes, start_time)
 
     def clobber_old_port_specific_results(self):
         if not self.get_option('disable_breakpad'):
             self._dump_reader.clobber_old_results()