third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py - Issue 2580293002: Style change: Rename error variables "e" -> "error"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

Issue 2580293002: Style change: Rename error variables "e" -> "error" (Closed)

Patch Set: Rebase and fix formatter unittest. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/formatter/main_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

index 2a29af4eec01abbdc1adffe35faad3953aa78651..a130a7d0657050c920e3cd88ec1089031150a3c6 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

@@ -124,8 +124,8 @@ class DumpReaderWin(DumpReader):

'%s\\Debuggers\\x86' % win_sdk,

'%s\\Debuggers\\x64' % win_sdk,

])

- except OSError as e:

- if e.errno != errno.ENOENT:

+ except OSError as error:

+ if error.errno != errno.ENOENT:

raise

for cdb_path in possible_cdb_locations: