third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py - Issue 2580293002: Style change: Rename error variables "e" -> "error"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py

Issue 2580293002: Style change: Rename error variables "e" -> "error" (Closed)

Patch Set: Rebase and fix formatter unittest. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/memoized_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py

index 5924e48186b32612db2e53f42359b0ad2b16f225..7198e02d58613be6e9e0614e422b05f1d0982208 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py

@@ -58,12 +58,12 @@ class NetworkTransaction(object):

while True:

try:

return request()

- except urllib2.HTTPError as e:

- if self._convert_404_to_None and e.code == 404:

+ except urllib2.HTTPError as error:

+ if self._convert_404_to_None and error.code == 404:

return None

self._check_for_timeout()

_log.warning("Received HTTP status %s loading \"%s\". Retrying in %s seconds...",

- e.code, e.filename, self._backoff_seconds)

+ error.code, error.filename, self._backoff_seconds)

self._sleep()

def _check_for_timeout(self):