third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py - Issue 2580293002: Style change: Rename error variables "e" -> "error"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

Issue 2580293002: Style change: Rename error variables "e" -> "error" (Closed)

Patch Set: Rebase and fix formatter unittest. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

index f73d641635c089dc97b3234aaffe673a93c3d770..11d3982c37e6f416413a95a6f091c689f5456702 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

@@ -119,8 +119,8 @@ class CommitAnnouncer(SingleServerIRCBot):

return False

try:

self.git.ensure_cleanly_tracking_remote_master()

- except ScriptError as e:

- _log.error('Failed to clean repository: %s', e)

+ except ScriptError as error:

+ _log.error('Failed to clean repository: %s', error)

return False

attempts = 1

@@ -139,9 +139,9 @@ class CommitAnnouncer(SingleServerIRCBot):

try:

self.git.pull(timeout_seconds=PULL_TIMEOUT_SECONDS)

return True

- except ScriptError as e:

- _log.error('Error pulling from server: %s', e)

- _log.error('Output: %s', e.output)

+ except ScriptError as error:

+ _log.error('Error pulling from server: %s', error)

+ _log.error('Output: %s', error.output)

attempts += 1

_log.error('Exceeded pull attempts')

_log.error('Aborting at time: %s', self._time())