third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py - Issue 2580293002: Style change: Rename error variables "e" -> "error"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py

Issue 2580293002: Style change: Rename error variables "e" -> "error" (Closed)

Patch Set: Rebase and fix formatter unittest. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/formatter/main_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py

index b4db25d1d428b6d3a971cfe4bb3ffa2709f0578b..ffb50a0efd82688dc99fa7f3965c3130fd41efc1 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py

@@ -67,8 +67,8 @@ class Workspace(object):

# So, for now we depend on the environment having "zip" installed (likely fails on Win32)

try:

self._executive.run_command(['zip', '-9', '-r', zip_path, '.'], cwd=source_path)

- except ScriptError as e:

- _log.error("Workspace.create_zip failed in %s:\n%s", source_path, e.message_with_output())

+ except ScriptError as error:

+ _log.error("Workspace.create_zip failed in %s:\n%s", source_path, error.message_with_output())

return None

return zip_class(zip_path)