Avoid the ptr.reset(new XXX()) anti-pattern

Avoid the ptr.reset(new XXX()) anti-pattern

Be suspicious of |new|.  This removes some of the
easy cases.

Review-Url: https://codereview.chromium.org/2571913002
Committed: https://pdfium.googlesource.com/pdfium/+/a9caab94c1f16929e5acf2676117224617d80f53

[Tom Sepez, 2016-12-13 21:04:39]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[Tom Sepez, 2016-12-13 21:25:30]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:25:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:27:23]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/3174)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-12-13 21:34:27]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:34:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-13 21:34:56]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-12-13 21:34:57]

Dan, ready for review.

[commit-bot: I haz the power, 2016-12-13 21:53:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:53:08]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-14 13:56:48]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-12-14 13:56:48]

lgtm

[commit-bot: I haz the power, 2016-12-14 13:56:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 13:57:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481723808262250,
"parent_rev": "992ecf7c189e5cabf43e5ad862511cf63d030966", "commit_rev":
"a9caab94c1f16929e5acf2676117224617d80f53"}

[commit-bot: I haz the power, 2016-12-14 13:57:13]

Description was changed from

==========
Avoid the ptr.reset(new XXX()) anti-pattern

Be suspicious of |new|.  This removes some of the
easy cases.
==========

to

==========
Avoid the ptr.reset(new XXX()) anti-pattern

Be suspicious of |new|.  This removes some of the
easy cases.

Review-Url: https://codereview.chromium.org/2571913002
Committed:
https://pdfium.googlesource.com/pdfium/+/a9caab94c1f16929e5acf2676117224617d8...
==========

[commit-bot: I haz the power, 2016-12-14 13:57:14]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/a9caab94c1f16929e5acf2676117224617d8...