Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: xfa/fxbarcode/BC_TwoDimWriter.cpp

Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "core/fxge/cfx_graphstatedata.h" 9 #include "core/fxge/cfx_graphstatedata.h"
10 #include "core/fxge/cfx_pathdata.h" 10 #include "core/fxge/cfx_pathdata.h"
11 #include "core/fxge/cfx_renderdevice.h" 11 #include "core/fxge/cfx_renderdevice.h"
12 #include "third_party/base/numerics/safe_math.h" 12 #include "third_party/base/numerics/safe_math.h"
13 #include "third_party/base/ptr_util.h"
13 #include "xfa/fxbarcode/BC_TwoDimWriter.h" 14 #include "xfa/fxbarcode/BC_TwoDimWriter.h"
14 #include "xfa/fxbarcode/BC_Writer.h" 15 #include "xfa/fxbarcode/BC_Writer.h"
15 #include "xfa/fxbarcode/common/BC_CommonBitMatrix.h" 16 #include "xfa/fxbarcode/common/BC_CommonBitMatrix.h"
16 17
17 CBC_TwoDimWriter::CBC_TwoDimWriter() : m_iCorrectLevel(1), m_bFixedSize(true) {} 18 CBC_TwoDimWriter::CBC_TwoDimWriter() : m_iCorrectLevel(1), m_bFixedSize(true) {}
18 19
19 CBC_TwoDimWriter::~CBC_TwoDimWriter() {} 20 CBC_TwoDimWriter::~CBC_TwoDimWriter() {}
20 21
21 void CBC_TwoDimWriter::RenderDeviceResult(CFX_RenderDevice* device, 22 void CBC_TwoDimWriter::RenderDeviceResult(CFX_RenderDevice* device,
22 const CFX_Matrix* matrix) { 23 const CFX_Matrix* matrix) {
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 multiY = multiX; 128 multiY = multiX;
128 } 129 }
129 int32_t leftPadding = (outputWidth - (inputWidth * multiX)) / 2; 130 int32_t leftPadding = (outputWidth - (inputWidth * multiX)) / 2;
130 int32_t topPadding = (outputHeight - (inputHeight * multiY)) / 2; 131 int32_t topPadding = (outputHeight - (inputHeight * multiY)) / 2;
131 if (leftPadding < 0) { 132 if (leftPadding < 0) {
132 leftPadding = 0; 133 leftPadding = 0;
133 } 134 }
134 if (topPadding < 0) { 135 if (topPadding < 0) {
135 topPadding = 0; 136 topPadding = 0;
136 } 137 }
137 m_output.reset(new CBC_CommonBitMatrix); 138 m_output = pdfium::MakeUnique<CBC_CommonBitMatrix>();
138 m_output->Init(outputWidth, outputHeight); 139 m_output->Init(outputWidth, outputHeight);
139 for (int32_t inputY = 0, outputY = topPadding; 140 for (int32_t inputY = 0, outputY = topPadding;
140 (inputY < inputHeight) && (outputY < outputHeight - multiY); 141 (inputY < inputHeight) && (outputY < outputHeight - multiY);
141 inputY++, outputY += multiY) { 142 inputY++, outputY += multiY) {
142 for (int32_t inputX = 0, outputX = leftPadding; 143 for (int32_t inputX = 0, outputX = leftPadding;
143 (inputX < inputWidth) && (outputX < outputWidth - multiX); 144 (inputX < inputWidth) && (outputX < outputWidth - multiX);
144 inputX++, outputX += multiX) { 145 inputX++, outputX += multiX) {
145 if (code[inputX + inputY * inputWidth] == 1) { 146 if (code[inputX + inputY * inputWidth] == 1) {
146 m_output->SetRegion(outputX, outputY, multiX, multiY, e); 147 m_output->SetRegion(outputX, outputY, multiX, multiY, e);
147 BC_EXCEPTION_CHECK_ReturnVoid(e); 148 BC_EXCEPTION_CHECK_ReturnVoid(e);
148 } 149 }
149 } 150 }
150 } 151 }
151 } 152 }
OLDNEW
« no previous file with comments | « xfa/fwl/theme/cfwl_widgettp.cpp ('k') | xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698