Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp

Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxbarcode/oned/BC_OneDimWriter.cpp ('k') | xfa/fxbarcode/pdf417/BC_PDF417.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2010 ZXing authors 8 * Copyright 2010 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
11 * you may not use this file except in compliance with the License. 11 * you may not use this file except in compliance with the License.
12 * You may obtain a copy of the License at 12 * You may obtain a copy of the License at
13 * 13 *
14 * http://www.apache.org/licenses/LICENSE-2.0 14 * http://www.apache.org/licenses/LICENSE-2.0
15 * 15 *
16 * Unless required by applicable law or agreed to in writing, software 16 * Unless required by applicable law or agreed to in writing, software
17 * distributed under the License is distributed on an "AS IS" BASIS, 17 * distributed under the License is distributed on an "AS IS" BASIS,
18 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 18 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
19 * See the License for the specific language governing permissions and 19 * See the License for the specific language governing permissions and
20 * limitations under the License. 20 * limitations under the License.
21 */ 21 */
22 22
23 #include "core/fxge/cfx_fxgedevice.h" 23 #include "core/fxge/cfx_fxgedevice.h"
24 #include "core/fxge/cfx_gemodule.h" 24 #include "core/fxge/cfx_gemodule.h"
25 #include "third_party/base/ptr_util.h"
25 #include "xfa/fxbarcode/BC_Writer.h" 26 #include "xfa/fxbarcode/BC_Writer.h"
26 #include "xfa/fxbarcode/oned/BC_OneDimWriter.h" 27 #include "xfa/fxbarcode/oned/BC_OneDimWriter.h"
27 #include "xfa/fxbarcode/oned/BC_OnedEAN13Writer.h" 28 #include "xfa/fxbarcode/oned/BC_OnedEAN13Writer.h"
28 #include "xfa/fxbarcode/oned/BC_OnedUPCAWriter.h" 29 #include "xfa/fxbarcode/oned/BC_OnedUPCAWriter.h"
29 30
30 CBC_OnedUPCAWriter::CBC_OnedUPCAWriter() { 31 CBC_OnedUPCAWriter::CBC_OnedUPCAWriter() {
31 m_bLeftPadding = true; 32 m_bLeftPadding = true;
32 m_bRightPadding = true; 33 m_bRightPadding = true;
33 } 34 }
34 35
35 void CBC_OnedUPCAWriter::Init() { 36 void CBC_OnedUPCAWriter::Init() {
36 m_subWriter.reset(new CBC_OnedEAN13Writer); 37 m_subWriter = pdfium::MakeUnique<CBC_OnedEAN13Writer>();
37 } 38 }
38 39
39 CBC_OnedUPCAWriter::~CBC_OnedUPCAWriter() {} 40 CBC_OnedUPCAWriter::~CBC_OnedUPCAWriter() {}
40 41
41 bool CBC_OnedUPCAWriter::CheckContentValidity(const CFX_WideStringC& contents) { 42 bool CBC_OnedUPCAWriter::CheckContentValidity(const CFX_WideStringC& contents) {
42 for (FX_STRSIZE i = 0; i < contents.GetLength(); ++i) { 43 for (FX_STRSIZE i = 0; i < contents.GetLength(); ++i) {
43 if (contents.GetAt(i) < '0' || contents.GetAt(i) > '9') 44 if (contents.GetAt(i) < '0' || contents.GetAt(i) > '9')
44 return false; 45 return false;
45 } 46 }
46 return true; 47 return true;
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 FX_Free(pCharPos); 272 FX_Free(pCharPos);
272 } 273 }
273 274
274 void CBC_OnedUPCAWriter::RenderResult(const CFX_WideStringC& contents, 275 void CBC_OnedUPCAWriter::RenderResult(const CFX_WideStringC& contents,
275 uint8_t* code, 276 uint8_t* code,
276 int32_t codeLength, 277 int32_t codeLength,
277 bool isDevice, 278 bool isDevice,
278 int32_t& e) { 279 int32_t& e) {
279 CBC_OneDimWriter::RenderResult(contents, code, codeLength, isDevice, e); 280 CBC_OneDimWriter::RenderResult(contents, code, codeLength, isDevice, e);
280 } 281 }
OLDNEW
« no previous file with comments | « xfa/fxbarcode/oned/BC_OneDimWriter.cpp ('k') | xfa/fxbarcode/pdf417/BC_PDF417.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698