Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: xfa/fxbarcode/oned/BC_OneDimWriter.cpp

Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2011 ZXing authors 8 * Copyright 2011 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
(...skipping 13 matching lines...) Expand all
24 24
25 #include <algorithm> 25 #include <algorithm>
26 #include <memory> 26 #include <memory>
27 27
28 #include "core/fxge/cfx_fxgedevice.h" 28 #include "core/fxge/cfx_fxgedevice.h"
29 #include "core/fxge/cfx_gemodule.h" 29 #include "core/fxge/cfx_gemodule.h"
30 #include "core/fxge/cfx_graphstatedata.h" 30 #include "core/fxge/cfx_graphstatedata.h"
31 #include "core/fxge/cfx_pathdata.h" 31 #include "core/fxge/cfx_pathdata.h"
32 #include "core/fxge/cfx_renderdevice.h" 32 #include "core/fxge/cfx_renderdevice.h"
33 #include "core/fxge/cfx_unicodeencodingex.h" 33 #include "core/fxge/cfx_unicodeencodingex.h"
34 #include "third_party/base/ptr_util.h"
34 #include "xfa/fxbarcode/BC_Writer.h" 35 #include "xfa/fxbarcode/BC_Writer.h"
35 #include "xfa/fxbarcode/common/BC_CommonBitMatrix.h" 36 #include "xfa/fxbarcode/common/BC_CommonBitMatrix.h"
36 37
37 CBC_OneDimWriter::CBC_OneDimWriter() { 38 CBC_OneDimWriter::CBC_OneDimWriter() {
38 m_locTextLoc = BC_TEXT_LOC_BELOWEMBED; 39 m_locTextLoc = BC_TEXT_LOC_BELOWEMBED;
39 m_bPrintChecksum = true; 40 m_bPrintChecksum = true;
40 m_iDataLenth = 0; 41 m_iDataLenth = 0;
41 m_bCalcChecksum = false; 42 m_bCalcChecksum = false;
42 m_pFont = nullptr; 43 m_pFont = nullptr;
43 m_fFontSize = 10; 44 m_fFontSize = 10;
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 } 436 }
436 } 437 }
437 int32_t outputWidth = codeLength; 438 int32_t outputWidth = codeLength;
438 if (!isDevice) { 439 if (!isDevice) {
439 outputWidth = (int32_t)(codeLength * m_multiple / dataLengthScale); 440 outputWidth = (int32_t)(codeLength * m_multiple / dataLengthScale);
440 } 441 }
441 m_barWidth = m_Width; 442 m_barWidth = m_Width;
442 if (!isDevice) { 443 if (!isDevice) {
443 m_barWidth = codeLength * m_multiple; 444 m_barWidth = codeLength * m_multiple;
444 } 445 }
445 m_output.reset(new CBC_CommonBitMatrix); 446 m_output = pdfium::MakeUnique<CBC_CommonBitMatrix>();
446 m_output->Init(outputWidth, outputHeight); 447 m_output->Init(outputWidth, outputHeight);
447 int32_t outputX = leftPadding * m_multiple; 448 int32_t outputX = leftPadding * m_multiple;
448 for (int32_t inputX = 0; inputX < codeOldLength; inputX++) { 449 for (int32_t inputX = 0; inputX < codeOldLength; inputX++) {
449 if (code[inputX] == 1) { 450 if (code[inputX] == 1) {
450 if (outputX >= outputWidth) { 451 if (outputX >= outputWidth) {
451 break; 452 break;
452 } 453 }
453 if (outputX + m_multiple > outputWidth && outputWidth - outputX > 0) { 454 if (outputX + m_multiple > outputWidth && outputWidth - outputX > 0) {
454 m_output->SetRegion(outputX, 0, outputWidth - outputX, outputHeight, e); 455 m_output->SetRegion(outputX, 0, outputWidth - outputX, outputHeight, e);
455 break; 456 break;
(...skipping 11 matching lines...) Expand all
467 468
468 CFX_WideString CBC_OneDimWriter::FilterContents( 469 CFX_WideString CBC_OneDimWriter::FilterContents(
469 const CFX_WideStringC& contents) { 470 const CFX_WideStringC& contents) {
470 return CFX_WideString(); 471 return CFX_WideString();
471 } 472 }
472 473
473 CFX_WideString CBC_OneDimWriter::RenderTextContents( 474 CFX_WideString CBC_OneDimWriter::RenderTextContents(
474 const CFX_WideStringC& contents) { 475 const CFX_WideStringC& contents) {
475 return CFX_WideString(); 476 return CFX_WideString();
476 } 477 }
OLDNEW
« no previous file with comments | « xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp ('k') | xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698