Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: xfa/fxgraphics/cfx_path.cpp

Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxgraphics/cfx_graphics.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxgraphics/cfx_path.h" 7 #include "xfa/fxgraphics/cfx_path.h"
8 8
9 #include "core/fxge/cfx_pathdata.h" 9 #include "core/fxge/cfx_pathdata.h"
10 #include "third_party/base/ptr_util.h"
10 #include "xfa/fxgraphics/cfx_path_generator.h" 11 #include "xfa/fxgraphics/cfx_path_generator.h"
11 12
12 CFX_Path::CFX_Path() {} 13 CFX_Path::CFX_Path() {}
13 14
14 FWL_Error CFX_Path::Create() { 15 FWL_Error CFX_Path::Create() {
15 if (m_generator) 16 if (m_generator)
16 return FWL_Error::PropertyInvalid; 17 return FWL_Error::PropertyInvalid;
17 18
18 m_generator.reset(new CFX_PathGenerator()); 19 m_generator = pdfium::MakeUnique<CFX_PathGenerator>();
19 return FWL_Error::Succeeded; 20 return FWL_Error::Succeeded;
20 } 21 }
21 22
22 CFX_Path::~CFX_Path() {} 23 CFX_Path::~CFX_Path() {}
23 24
24 FWL_Error CFX_Path::MoveTo(FX_FLOAT x, FX_FLOAT y) { 25 FWL_Error CFX_Path::MoveTo(FX_FLOAT x, FX_FLOAT y) {
25 if (!m_generator) 26 if (!m_generator)
26 return FWL_Error::PropertyInvalid; 27 return FWL_Error::PropertyInvalid;
27 m_generator->MoveTo(x, y); 28 m_generator->MoveTo(x, y);
28 return FWL_Error::Succeeded; 29 return FWL_Error::Succeeded;
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 if (m_generator->GetPathData()->GetPointCount() == 0) 169 if (m_generator->GetPathData()->GetPointCount() == 0)
169 return true; 170 return true;
170 return false; 171 return false;
171 } 172 }
172 173
173 CFX_PathData* CFX_Path::GetPathData() const { 174 CFX_PathData* CFX_Path::GetPathData() const {
174 if (!m_generator) 175 if (!m_generator)
175 return nullptr; 176 return nullptr;
176 return m_generator->GetPathData(); 177 return m_generator->GetPathData();
177 } 178 }
OLDNEW
« no previous file with comments | « xfa/fxgraphics/cfx_graphics.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698