xfa/fwl/cfwl_widgetmgr.cpp - Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/cfwl_widgetmgr.cpp

Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/cfwl_widgetmgr.cpp

diff --git a/xfa/fwl/cfwl_widgetmgr.cpp b/xfa/fwl/cfwl_widgetmgr.cpp

index e7eca100cc165c724b37c5ca9e15e82f69e63e2b..7df7fb234d46cba97adaefa20b95dc1ccbdc5536 100644

--- a/xfa/fwl/cfwl_widgetmgr.cpp

+++ b/xfa/fwl/cfwl_widgetmgr.cpp

@@ -563,7 +563,7 @@ CFX_Graphics* CFWL_WidgetMgr::DrawWidgetBefore(CFWL_Widget* pWidget,

Item* pItem = GetWidgetMgrItem(pWidget);

if (!pItem->pOffscreen) {

- pItem->pOffscreen.reset(new CFX_Graphics);

+ pItem->pOffscreen = pdfium::MakeUnique<CFX_Graphics>();

CFX_RectF rect = pWidget->GetWidgetRect();

pItem->pOffscreen->Create((int32_t)rect.width, (int32_t)rect.height,

FXDIB_Argb);

« no previous file with comments | « xfa/fwl/cfwl_datetimepicker.cpp ('k') | xfa/fwl/theme/cfwl_checkboxtp.cpp » ('j') | no next file with comments »