xfa/fde/cfde_txtedtengine.cpp - Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(191)

My Issues | Starred Open | Closed | All

Unified Diff: xfa/fde/cfde_txtedtengine.cpp

Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « fpdfsdk/fpdfdoc_unittest.cpp ('k') | xfa/fde/cfde_txtedtpage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/fde/cfde_txtedtengine.cpp

diff --git a/xfa/fde/cfde_txtedtengine.cpp b/xfa/fde/cfde_txtedtengine.cpp

index ced5bdca527cc087fc092c73e8ff14f7aaac0d30..7df4e0fb96cacdc2e608383f85a94746d7594920 100644

--- a/xfa/fde/cfde_txtedtengine.cpp

+++ b/xfa/fde/cfde_txtedtengine.cpp

@@ -82,7 +82,7 @@ CFDE_TxtEdtEngine::~CFDE_TxtEdtEngine() {

void CFDE_TxtEdtEngine::SetEditParams(const FDE_TXTEDTPARAMS& params) {

if (!m_pTextBreak)

- m_pTextBreak.reset(new CFX_TxtBreak(FX_TXTBREAKPOLICY_None));

+ m_pTextBreak = pdfium::MakeUnique<CFX_TxtBreak>(FX_TXTBREAKPOLICY_None);

FXSYS_memcpy(&m_Param, &params, sizeof(FDE_TXTEDTPARAMS));

m_wLineEnd = params.wLineBreakChar;

« no previous file with comments | « fpdfsdk/fpdfdoc_unittest.cpp ('k') | xfa/fde/cfde_txtedtpage.cpp » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698