Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

Issue 2571913002: Avoid the ptr.reset(new XXX()) anti-pattern (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxbarcode/BC_TwoDimWriter.cpp ('k') | xfa/fxbarcode/oned/BC_OneDimWriter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2007 ZXing authors 8 * Copyright 2007 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
11 * you may not use this file except in compliance with the License. 11 * you may not use this file except in compliance with the License.
12 * You may obtain a copy of the License at 12 * You may obtain a copy of the License at
13 * 13 *
14 * http://www.apache.org/licenses/LICENSE-2.0 14 * http://www.apache.org/licenses/LICENSE-2.0
15 * 15 *
16 * Unless required by applicable law or agreed to in writing, software 16 * Unless required by applicable law or agreed to in writing, software
17 * distributed under the License is distributed on an "AS IS" BASIS, 17 * distributed under the License is distributed on an "AS IS" BASIS,
18 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 18 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
19 * See the License for the specific language governing permissions and 19 * See the License for the specific language governing permissions and
20 * limitations under the License. 20 * limitations under the License.
21 */ 21 */
22 22
23 #include "xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h" 23 #include "xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h"
24
25 #include "third_party/base/ptr_util.h"
24 #include "xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h" 26 #include "xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h"
25 27
26 CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::QRCodeField = nullptr; 28 CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::QRCodeField = nullptr;
27 CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::DataMatrixField = nullptr; 29 CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::DataMatrixField = nullptr;
28 30
29 void CBC_ReedSolomonGF256::Initialize() { 31 void CBC_ReedSolomonGF256::Initialize() {
30 QRCodeField = new CBC_ReedSolomonGF256(0x011D); 32 QRCodeField = new CBC_ReedSolomonGF256(0x011D);
31 QRCodeField->Init(); 33 QRCodeField->Init();
32 DataMatrixField = new CBC_ReedSolomonGF256(0x012D); 34 DataMatrixField = new CBC_ReedSolomonGF256(0x012D);
33 DataMatrixField->Init(); 35 DataMatrixField->Init();
(...skipping 15 matching lines...) Expand all
49 x ^= primitive; 51 x ^= primitive;
50 } 52 }
51 } 53 }
52 for (int32_t i = 0; i < 255; i++) { 54 for (int32_t i = 0; i < 255; i++) {
53 m_logTable[m_expTable[i]] = i; 55 m_logTable[m_expTable[i]] = i;
54 } 56 }
55 m_logTable[0] = 0; 57 m_logTable[0] = 0;
56 } 58 }
57 59
58 void CBC_ReedSolomonGF256::Init() { 60 void CBC_ReedSolomonGF256::Init() {
59 m_zero.reset(new CBC_ReedSolomonGF256Poly(this, 0)); 61 m_zero = pdfium::MakeUnique<CBC_ReedSolomonGF256Poly>(this, 0);
60 m_one.reset(new CBC_ReedSolomonGF256Poly(this, 1)); 62 m_one = pdfium::MakeUnique<CBC_ReedSolomonGF256Poly>(this, 1);
61 } 63 }
62 64
63 CBC_ReedSolomonGF256::~CBC_ReedSolomonGF256() {} 65 CBC_ReedSolomonGF256::~CBC_ReedSolomonGF256() {}
64 66
65 CBC_ReedSolomonGF256Poly* CBC_ReedSolomonGF256::GetZero() const { 67 CBC_ReedSolomonGF256Poly* CBC_ReedSolomonGF256::GetZero() const {
66 return m_zero.get(); 68 return m_zero.get();
67 } 69 }
68 70
69 CBC_ReedSolomonGF256Poly* CBC_ReedSolomonGF256::GetOne() const { 71 CBC_ReedSolomonGF256Poly* CBC_ReedSolomonGF256::GetOne() const {
70 return m_one.get(); 72 return m_one.get();
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 return 0; 123 return 0;
122 } 124 }
123 if (a == 1) { 125 if (a == 1) {
124 return b; 126 return b;
125 } 127 }
126 if (b == 1) { 128 if (b == 1) {
127 return a; 129 return a;
128 } 130 }
129 return m_expTable[(m_logTable[a] + m_logTable[b]) % 255]; 131 return m_expTable[(m_logTable[a] + m_logTable[b]) % 255];
130 } 132 }
OLDNEW
« no previous file with comments | « xfa/fxbarcode/BC_TwoDimWriter.cpp ('k') | xfa/fxbarcode/oned/BC_OneDimWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698