[DevTools] Remove methods on Common.Event.

[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from Common.Event.

BUG=none

Committed: https://crrev.com/cd3e789d9ae61c3028d05d9e3361198496b45412
Cr-Commit-Position: refs/heads/master@{#437987}

[dgozman, 2016-12-06 15:28:47]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2016-12-06 15:29:00]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2016-12-06 15:29:01]

Take a look please.

[commit-bot: I haz the power, 2016-12-06 15:29:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 17:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 17:55:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-12-06 20:21:51]

lgtm

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-test.js
(left):

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-test.js:36:
if (!event.data || event.type === SDK.DOMModel.Events.MarkersChanged ||
event.type === SDK.DOMModel.Events.DOMMutated)
i'm surprised this didn't break a lot of tests

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:366:
* @param {!SDK.DebuggerPausedDetails} debuggerPausedDetails
jsdoc: @return is missing

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
(right):

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js:94:
this.update();
nit: we can just inline this

[dgozman, 2016-12-06 21:36:16]

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-test.js
(left):

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-test.js:36:
if (!event.data || event.type === SDK.DOMModel.Events.MarkersChanged ||
event.type === SDK.DOMModel.Events.DOMMutated)
On 2016/12/06 20:21:51, lushnikov wrote:
> i'm surprised this didn't break a lot of tests

Well, I just don't add the listener in step3().

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:366:
* @param {!SDK.DebuggerPausedDetails} debuggerPausedDetails
On 2016/12/06 20:21:51, lushnikov wrote:
> jsdoc: @return is missing

Done.

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
(right):

https://codereview.chromium.org/2553043003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js:94:
this.update();
On 2016/12/06 20:21:51, lushnikov wrote:
> nit: we can just inline this

Done.

[dgozman, 2016-12-06 21:36:21]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-06 21:36:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2553043003/#ps20001
(title: "review fixes")

[commit-bot: I haz the power, 2016-12-06 21:37:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:43:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481060181701160,
"parent_rev": "1155fa4e299ba87f6c80f2325aef2b5ab038b954", "commit_rev":
"79de77dfbdbe9017a75223ebbee4a8ff62393c6c"}

[commit-bot: I haz the power, 2016-12-07 00:43:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 00:46:01]

Description was changed from

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none
==========

to

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none

Committed: https://crrev.com/ded3e43b7d536317c1041725ff41dcb15177d8fc
Cr-Commit-Position: refs/heads/master@{#436788}
==========

[commit-bot: I haz the power, 2016-12-07 00:46:04]

Patchset 2 (id:??) landed as
https://crrev.com/ded3e43b7d536317c1041725ff41dcb15177d8fc
Cr-Commit-Position: refs/heads/master@{#436788}

[dgozman, 2016-12-07 19:29:08]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2560553004/ by dgozman@chromium.org.

The reason for reverting is: Broke toolbar buttons. See issue 671936, 672020,
671984..

[dgozman, 2016-12-09 01:30:31]

Description was changed from

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none

Committed: https://crrev.com/ded3e43b7d536317c1041725ff41dcb15177d8fc
Cr-Commit-Position: refs/heads/master@{#436788}
==========

to

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none
==========

[dgozman, 2016-12-09 21:39:11]

Please take another look. Last time I forgot about ToolbarToogle instances which
inherit from ToolbarButton.

[lushnikov, 2016-12-10 01:16:00]

lgtm

[dgozman, 2016-12-10 01:53:10]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 03:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 03:46:04]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2016-12-10 04:09:38]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-10 04:09:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 04:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 04:18:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2016-12-12 22:08:56]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-12 22:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2553043003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-12-12 22:09:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:25:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481580536028590,
"parent_rev": "17936ce88d071a78b515251587f1eaa6d676925e", "commit_rev":
"68f357148341f5dec9d5bbbcaa1dbfc9882d819e"}

[commit-bot: I haz the power, 2016-12-13 02:25:53]

Description was changed from

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none
==========

to

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none

Review-Url: https://codereview.chromium.org/2553043003
==========

[commit-bot: I haz the power, 2016-12-13 02:25:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 02:28:15]

Description was changed from

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none

Review-Url: https://codereview.chromium.org/2553043003
==========

to

==========
[DevTools] Remove methods on Common.Event.

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from
Common.Event.

BUG=none

Committed: https://crrev.com/cd3e789d9ae61c3028d05d9e3361198496b45412
Cr-Commit-Position: refs/heads/master@{#437987}
==========

[commit-bot: I haz the power, 2016-12-13 02:28:16]

Patchset 4 (id:??) landed as
https://crrev.com/cd3e789d9ae61c3028d05d9e3361198496b45412
Cr-Commit-Position: refs/heads/master@{#437987}

[luoe, 2016-12-14 23:53:10]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2573323002/ by luoe@chromium.org.

The reason for reverting is: Compromises the ability to add new watch
expressions and XHR Breakpoints.

In the debugger sidepane, Watch Expressions and XHR sections have a '+' icon
when open.  Clicking on the '+' should add a new entry, but instead it closes
the section..