Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
index 69b130be8540cce69437fc62a31fef6fcc7dccf3..d21e64411a579118adf8c898517d6dcf3d3b6518 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
@@ -16,7 +16,7 @@ Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP
this._breakpointElements = new Map();
this._addButton = new UI.ToolbarButton(Common.UIString('Add breakpoint'), 'largeicon-add');
- this._addButton.addEventListener('click', this._addButtonClicked.bind(this));
+ this._addButton.addEventListener(UI.ToolbarButton.Events.Click, this._addButtonClicked.bind(this));
this.emptyElement.addEventListener('contextmenu', this._emptyElementContextMenu.bind(this), true);
SDK.targetManager.observeTargets(this, SDK.Target.Capability.Browser);
@@ -52,10 +52,7 @@ Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP
contextMenu.show();
}
- _addButtonClicked(event) {
- if (event)
- event.consume();
-
+ _addButtonClicked() {
UI.viewManager.showView('sources.xhrBreakpoints');
var inputElementContainer = createElementWithClass('p', 'breakpoint-condition');

Powered by Google App Engine
This is Rietveld 408576698