third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js - Issue 2553043003: [DevTools] Remove methods on Common.Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)

Patch Set: rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

index 5e3690c2d44eb00dbd0c5b09b00401b562f4f7a3..200b299495290906d7bf5477768efdbe4bea12d5 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

@@ -18,10 +18,10 @@ Network.BlockedURLsPane = class extends UI.VBox {

this._toolbar = new UI.Toolbar('', this.contentElement);

this._toolbar.element.addEventListener('click', (e) => e.consume());

var addButton = new UI.ToolbarButton(Common.UIString('Add pattern'), 'largeicon-add');

- addButton.addEventListener('click', this._addButtonClicked.bind(this));

+ addButton.addEventListener(UI.ToolbarButton.Events.Click, this._addButtonClicked, this);

this._toolbar.appendToolbarItem(addButton);

var clearButton = new UI.ToolbarButton(Common.UIString('Remove all'), 'largeicon-clear');

- clearButton.addEventListener('click', this._removeAll.bind(this));

+ clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._removeAll, this);

this._toolbar.appendToolbarItem(clearButton);

this._emptyElement = this.contentElement.createChild('div', 'no-blocked-urls');