Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
index c7ca87715f4f6514eb034f2129f7dacf6312b15f..bbd952e155b5501e06dfb5626d427baca2f847ce 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
@@ -154,18 +154,18 @@ Resources.ServiceWorkersView.Section = class {
this._toolbar = section.createToolbar();
this._toolbar.renderAsLinks();
this._updateButton = new UI.ToolbarButton(Common.UIString('Update'), undefined, Common.UIString('Update'));
- this._updateButton.addEventListener('click', this._updateButtonClicked.bind(this));
+ this._updateButton.addEventListener(UI.ToolbarButton.Events.Click, this._updateButtonClicked, this);
this._toolbar.appendToolbarItem(this._updateButton);
this._pushButton = new UI.ToolbarButton(Common.UIString('Emulate push event'), undefined, Common.UIString('Push'));
- this._pushButton.addEventListener('click', this._pushButtonClicked.bind(this));
+ this._pushButton.addEventListener(UI.ToolbarButton.Events.Click, this._pushButtonClicked, this);
this._toolbar.appendToolbarItem(this._pushButton);
this._syncButton =
new UI.ToolbarButton(Common.UIString('Emulate background sync event'), undefined, Common.UIString('Sync'));
- this._syncButton.addEventListener('click', this._syncButtonClicked.bind(this));
+ this._syncButton.addEventListener(UI.ToolbarButton.Events.Click, this._syncButtonClicked, this);
this._toolbar.appendToolbarItem(this._syncButton);
this._deleteButton =
new UI.ToolbarButton(Common.UIString('Unregister service worker'), undefined, Common.UIString('Unregister'));
- this._deleteButton.addEventListener('click', this._unregisterButtonClicked.bind(this));
+ this._deleteButton.addEventListener(UI.ToolbarButton.Events.Click, this._unregisterButtonClicked, this);
this._toolbar.appendToolbarItem(this._deleteButton);
// Preserve the order.
@@ -318,20 +318,32 @@ Resources.ServiceWorkersView.Section = class {
message.appendChild(createLabel('#' + error.versionId + ': ' + error.errorMessage, 'smallicon-error'));
}
- _unregisterButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _unregisterButtonClicked(event) {
this._manager.deleteRegistration(this._registration.id);
}
- _updateButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _updateButtonClicked(event) {
this._manager.updateRegistration(this._registration.id);
}
- _pushButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _pushButtonClicked(event) {
var data = 'Test push message from DevTools.';
this._manager.deliverPushMessage(this._registration.id, data);
}
- _syncButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _syncButtonClicked(event) {
var tag = 'test-tag-from-devtools';
var lastChance = true;
this._manager.dispatchSyncEvent(this._registration.id, tag, lastChance);

Powered by Google App Engine
This is Rietveld 408576698