Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
index 60fcf439d074939482ae349357084dac86767572..4c0c48503e590de0df05c357728aff32715beab0 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -411,8 +411,8 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
this._isPausing = false;
this._debuggerPausedDetails = debuggerPausedDetails;
if (this._debuggerPausedDetails) {
- if (Runtime.experiments.isEnabled('emptySourceMapAutoStepping')) {
- if (this.dispatchEventToListeners(SDK.DebuggerModel.Events.BeforeDebuggerPaused, this._debuggerPausedDetails))
+ if (Runtime.experiments.isEnabled('emptySourceMapAutoStepping') && this._beforePausedCallback) {
+ if (!this._beforePausedCallback.call(null, this._debuggerPausedDetails))
return false;
}
this.dispatchEventToListeners(SDK.DebuggerModel.Events.DebuggerPaused, this._debuggerPausedDetails);
@@ -425,6 +425,13 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
}
/**
+ * @param {?function(!SDK.DebuggerPausedDetails):boolean} callback
+ */
+ setBeforePausedCallback(callback) {
+ this._beforePausedCallback = callback;
+ }
+
+ /**
* @param {!Array.<!Protocol.Debugger.CallFrame>} callFrames
* @param {string} reason
* @param {!Object|undefined} auxData
@@ -807,7 +814,6 @@ SDK.DebuggerModel.PauseOnExceptionsState = {
SDK.DebuggerModel.Events = {
DebuggerWasEnabled: Symbol('DebuggerWasEnabled'),
DebuggerWasDisabled: Symbol('DebuggerWasDisabled'),
- BeforeDebuggerPaused: Symbol('BeforeDebuggerPaused'),
DebuggerPaused: Symbol('DebuggerPaused'),
DebuggerResumed: Symbol('DebuggerResumed'),
ParsedScriptSource: Symbol('ParsedScriptSource'),

Powered by Google App Engine
This is Rietveld 408576698