Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js b/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
index 0b4a5896e3eae942c777a2b9cf07256426ccf07a..b68d654a4f0b182c172f9567ef2abc903f751096 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
@@ -99,10 +99,10 @@ Resources.IDBDataView = class extends UI.SimpleView {
this._createEditorToolbar();
this._refreshButton = new UI.ToolbarButton(Common.UIString('Refresh'), 'largeicon-refresh');
- this._refreshButton.addEventListener('click', this._refreshButtonClicked, this);
+ this._refreshButton.addEventListener(UI.ToolbarButton.Events.Click, this._refreshButtonClicked, this);
this._clearButton = new UI.ToolbarButton(Common.UIString('Clear object store'), 'largeicon-clear');
- this._clearButton.addEventListener('click', this._clearButtonClicked, this);
+ this._clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clearButtonClicked, this);
this._pageSize = 50;
this._skipCount = 0;
@@ -179,12 +179,12 @@ Resources.IDBDataView = class extends UI.SimpleView {
var editorToolbar = new UI.Toolbar('data-view-toolbar', this.element);
this._pageBackButton = new UI.ToolbarButton(Common.UIString('Show previous page'), 'largeicon-play-back');
- this._pageBackButton.addEventListener('click', this._pageBackButtonClicked, this);
+ this._pageBackButton.addEventListener(UI.ToolbarButton.Events.Click, this._pageBackButtonClicked, this);
editorToolbar.appendToolbarItem(this._pageBackButton);
this._pageForwardButton = new UI.ToolbarButton(Common.UIString('Show next page'), 'largeicon-play');
this._pageForwardButton.setEnabled(false);
- this._pageForwardButton.addEventListener('click', this._pageForwardButtonClicked, this);
+ this._pageForwardButton.addEventListener(UI.ToolbarButton.Events.Click, this._pageForwardButtonClicked, this);
editorToolbar.appendToolbarItem(this._pageForwardButton);
this._keyInputElement = editorToolbar.element.createChild('input', 'key-input');
@@ -195,12 +195,18 @@ Resources.IDBDataView = class extends UI.SimpleView {
this._keyInputElement.addEventListener('keydown', this._keyInputChanged.bind(this), false);
}
- _pageBackButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _pageBackButtonClicked(event) {
this._skipCount = Math.max(0, this._skipCount - this._pageSize);
this._updateData(false);
}
- _pageForwardButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _pageForwardButtonClicked(event) {
this._skipCount = this._skipCount + this._pageSize;
this._updateData(false);
}
@@ -295,10 +301,16 @@ Resources.IDBDataView = class extends UI.SimpleView {
}
}
+ /**
+ * @param {!Common.Event} event
+ */
_refreshButtonClicked(event) {
this._updateData(true);
}
+ /**
+ * @param {!Common.Event} event
+ */
_clearButtonClicked(event) {
/**
* @this {Resources.IDBDataView}

Powered by Google App Engine
This is Rietveld 408576698