Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
index c30218d1957cc683041e47b67895c17bd13ec3a8..e3b4cad864bae9674d7b8556814d03fec0e45943 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
@@ -34,15 +34,15 @@ Profiler.ProfileView = class extends UI.SimpleView {
this.focusButton = new UI.ToolbarButton(Common.UIString('Focus selected function'), 'largeicon-visibility');
this.focusButton.setEnabled(false);
- this.focusButton.addEventListener('click', this._focusClicked, this);
+ this.focusButton.addEventListener(UI.ToolbarButton.Events.Click, this._focusClicked, this);
this.excludeButton = new UI.ToolbarButton(Common.UIString('Exclude selected function'), 'largeicon-delete');
this.excludeButton.setEnabled(false);
- this.excludeButton.addEventListener('click', this._excludeClicked, this);
+ this.excludeButton.addEventListener(UI.ToolbarButton.Events.Click, this._excludeClicked, this);
this.resetButton = new UI.ToolbarButton(Common.UIString('Restore all functions'), 'largeicon-refresh');
this.resetButton.setEnabled(false);
- this.resetButton.addEventListener('click', this._resetClicked, this);
+ this.resetButton.addEventListener(UI.ToolbarButton.Events.Click, this._resetClicked, this);
this._linkifier = new Components.Linkifier(Profiler.ProfileView._maxLinkLength);
}
@@ -325,6 +325,9 @@ Profiler.ProfileView = class extends UI.SimpleView {
this.excludeButton.setEnabled(selected);
}
+ /**
+ * @param {!Common.Event} event
+ */
_focusClicked(event) {
if (!this.dataGrid.selectedNode)
return;
@@ -335,6 +338,9 @@ Profiler.ProfileView = class extends UI.SimpleView {
this.refreshVisibleData();
}
+ /**
+ * @param {!Common.Event} event
+ */
_excludeClicked(event) {
var selectedNode = this.dataGrid.selectedNode;
@@ -349,6 +355,9 @@ Profiler.ProfileView = class extends UI.SimpleView {
this.refreshVisibleData();
}
+ /**
+ * @param {!Common.Event} event
+ */
_resetClicked(event) {
this.resetButton.setEnabled(false);
this.profileDataGridTree.restore();

Powered by Google App Engine
This is Rietveld 408576698