Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
index c3346448c25157813f11d2f4b6228260a7e842bb..42c424c9b6fe536cbc47372708efb6e8cc9e841f 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
@@ -38,14 +38,14 @@ Resources.CookieItemsView = class extends UI.SimpleView {
this._deleteButton = new UI.ToolbarButton(Common.UIString('Delete'), 'largeicon-delete');
this._deleteButton.setVisible(false);
- this._deleteButton.addEventListener('click', this._deleteButtonClicked, this);
+ this._deleteButton.addEventListener(UI.ToolbarButton.Events.Click, this._deleteButtonClicked, this);
this._clearButton = new UI.ToolbarButton(Common.UIString('Clear'), 'largeicon-clear');
this._clearButton.setVisible(false);
- this._clearButton.addEventListener('click', this._clearButtonClicked, this);
+ this._clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clearButtonClicked, this);
this._refreshButton = new UI.ToolbarButton(Common.UIString('Refresh'), 'largeicon-refresh');
- this._refreshButton.addEventListener('click', this._refreshButtonClicked, this);
+ this._refreshButton.addEventListener(UI.ToolbarButton.Events.Click, this._refreshButtonClicked, this);
this._treeElement = treeElement;
this._cookieDomain = cookieDomain;
@@ -156,7 +156,10 @@ Resources.CookieItemsView = class extends UI.SimpleView {
this._update();
}
- _clearButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _clearButtonClicked(event) {
this.clear();
}
@@ -164,7 +167,10 @@ Resources.CookieItemsView = class extends UI.SimpleView {
this._deleteButton.setVisible(true);
}
- _deleteButtonClicked() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _deleteButtonClicked(event) {
var selectedCookie = this._cookiesTable.selectedCookie();
if (selectedCookie) {
selectedCookie.remove();
@@ -172,6 +178,9 @@ Resources.CookieItemsView = class extends UI.SimpleView {
}
}
+ /**
+ * @param {!Common.Event} event
+ */
_refreshButtonClicked(event) {
this._update();
}

Powered by Google App Engine
This is Rietveld 408576698