Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2543313002: ui/gl: rename ClearGLBindings to ShutdownGL (Closed)

Created:
4 years ago by Corentin Wallez
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, feature-vr-reviews_chromium.org, kalyank, mac-reviews_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/gl: rename ClearGLBindings to ShutdownGL When initializing ui/gl, the GL bindings are first populated, then the PlatformOneOff initialization is done. ClearGLBindings is currently used by tests and the vr_shell to completely deinit the GL, not just clearing the bindings. Rename it accordingly. BUG=angleproject:1621 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3f8acfcbdadd2169715385a4348f53c19dd0942f Cr-Commit-Position: refs/heads/master@{#436071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/android_video_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_egl_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_glx_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_osmesa_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_osmesa_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_wgl_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gpu_timing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/init/gl_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/init/gl_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/init/gl_initializer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/init/gl_initializer_android.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gl/init/gl_initializer_mac.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gl/init/gl_initializer_ozone.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gl/init/gl_initializer_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gl/init/gl_initializer_x11.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gl/test/gl_image_test_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/test/gl_surface_test_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/common/gl_ozone_egl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/common/gl_ozone_egl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/x11/gl_ozone_glx.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/x11/gl_ozone_glx.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/public/gl_ozone.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Corentin Wallez
kbr: PTAL, this is the renaming for https://codereview.chromium.org/2491993002 thakis, bajones, liberato: this rename touches some ...
4 years ago (2016-12-02 20:52:35 UTC) #5
liberato (no reviews please)
media/ lgtm.
4 years ago (2016-12-02 21:00:33 UTC) #6
Nico
rs-lgtm if kbr likes this. (Note: There's talk every now and then to remove "shutdown" ...
4 years ago (2016-12-02 21:02:51 UTC) #7
bajones
vr_shell/ LGTM
4 years ago (2016-12-02 21:38:09 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
4 years ago (2016-12-02 22:55:34 UTC) #11
Corentin Wallez
Thank you all for the review.
4 years ago (2016-12-02 23:01:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543313002/1
4 years ago (2016-12-02 23:02:41 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 23:10:32 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-02 23:13:20 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f8acfcbdadd2169715385a4348f53c19dd0942f
Cr-Commit-Position: refs/heads/master@{#436071}

Powered by Google App Engine
This is Rietveld 408576698