NewTabPage: Remove impression/click ping plumbing for local NTP

NewTabPage: Remove impression/click ping plumbing for local NTP

This plumbing was never actually used, and we're now getting rid of the pings completely.

BUG=646308
Committed: https://crrev.com/27891919ba0f1465b7e7eee68196eb51b1df8e01
Cr-Commit-Position: refs/heads/master@{#434946}

[Marc Treib, 2016-11-22 14:31:35]

Description was changed from

==========
NewTabPage: Remove impression/click pings

BUG=667723
==========

to

==========
NewTabPage: Remove impression/click pings

BUG=667723
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Marc Treib, 2016-11-22 14:31:39]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 14:31:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 15:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:24:59]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-24 13:22:56]

treib@chromium.org changed reviewers:
+ mastiz@chromium.org

[Marc Treib, 2016-11-24 13:22:57]

PTAL - as far as I can tell, this was all the impression/click ping code in
Chromium.

[Marc Treib, 2016-11-24 13:24:26]

(Of course, I won't land this until we have actually finally decided to remove
it)

[Marc Treib, 2016-11-28 13:36:44]

Description was changed from

==========
NewTabPage: Remove impression/click pings

BUG=667723
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
NewTabPage: Remove impression/click pings

BUG=646308
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mastiz, 2016-11-28 13:46:22]

Great!

LGTM

https://codereview.chromium.org/2525653002/diff/1/chrome/browser/resources/lo...
File chrome/browser/resources/local_ntp/most_visited_single.js (left):

https://codereview.chromium.org/2525653002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/most_visited_single.js:90: 
As discussed offline, I'd prefer if the javascript part gets split to a
dedicated CL.

https://codereview.chromium.org/2525653002/diff/1/components/suggestions/prot...
File components/suggestions/proto/suggestions.proto (left):

https://codereview.chromium.org/2525653002/diff/1/components/suggestions/prot...
components/suggestions/proto/suggestions.proto:58: optional string click_url =
14;
Can you please either:
a) Mark field tags 13 and 14 as reserved.
b) Add a comment higher up saying: "Next ID: 15".

[Marc Treib, 2016-11-28 13:56:36]

Description was changed from

==========
NewTabPage: Remove impression/click pings

BUG=646308
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
NewTabPage: Remove impression/click ping plumbing for local NTP

BUG=646308
==========

[Marc Treib, 2016-11-28 13:56:47]

https://codereview.chromium.org/2525653002/diff/1/chrome/browser/resources/lo...
File chrome/browser/resources/local_ntp/most_visited_single.js (left):

https://codereview.chromium.org/2525653002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/most_visited_single.js:90: 
On 2016/11/28 13:46:22, mastiz wrote:
> As discussed offline, I'd prefer if the javascript part gets split to a
> dedicated CL.

Done.

https://codereview.chromium.org/2525653002/diff/1/components/suggestions/prot...
File components/suggestions/proto/suggestions.proto (left):

https://codereview.chromium.org/2525653002/diff/1/components/suggestions/prot...
components/suggestions/proto/suggestions.proto:58: optional string click_url =
14;
On 2016/11/28 13:46:22, mastiz wrote:
> Can you please either:
> a) Mark field tags 13 and 14 as reserved.
> b) Add a comment higher up saying: "Next ID: 15".

There already is a comment above ("Next tag: 15")

[Marc Treib, 2016-11-28 13:57:11]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 13:57:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-11-28 14:01:53]

Description was changed from

==========
NewTabPage: Remove impression/click ping plumbing for local NTP

BUG=646308
==========

to

==========
NewTabPage: Remove impression/click ping plumbing for local NTP

This plumbing was never actually used, and we're now getting rid of the pings
completely.

BUG=646308
==========

[commit-bot: I haz the power, 2016-11-28 14:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 14:37:44]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-28 14:42:07]

treib@chromium.org changed reviewers:
+ nasko@chromium.org

[Marc Treib, 2016-11-28 14:42:07]

+nasko for IPC - PTAL at render_messages.h, thanks!

[nasko, 2016-11-28 19:27:13]

IPC LGTM

[Marc Treib, 2016-11-29 10:15:33]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-11-29 10:15:34]

The patchset sent to the CQ was uploaded after l-g-t-m from mastiz@chromium.org
Link to the patchset: https://codereview.chromium.org/2525653002/#ps20001
(title: "undo JS changes")

[commit-bot: I haz the power, 2016-11-29 10:16:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 10:22:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480414533974960,
"parent_rev": "2bbbafe5d202457baec3c6da44f384eb75a33b56", "commit_rev":
"7edca0bc39ce412802facd700fa44d90125ba47b"}

[commit-bot: I haz the power, 2016-11-29 10:23:00]

Description was changed from

==========
NewTabPage: Remove impression/click ping plumbing for local NTP

This plumbing was never actually used, and we're now getting rid of the pings
completely.

BUG=646308
==========

to

==========
NewTabPage: Remove impression/click ping plumbing for local NTP

This plumbing was never actually used, and we're now getting rid of the pings
completely.

BUG=646308
==========

[commit-bot: I haz the power, 2016-11-29 10:23:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 10:26:18]

Description was changed from

==========
NewTabPage: Remove impression/click ping plumbing for local NTP

This plumbing was never actually used, and we're now getting rid of the pings
completely.

BUG=646308
==========

to

==========
NewTabPage: Remove impression/click ping plumbing for local NTP

This plumbing was never actually used, and we're now getting rid of the pings
completely.

BUG=646308

Committed: https://crrev.com/27891919ba0f1465b7e7eee68196eb51b1df8e01
Cr-Commit-Position: refs/heads/master@{#434946}
==========

[commit-bot: I haz the power, 2016-11-29 10:26:19]

Patchset 2 (id:??) landed as
https://crrev.com/27891919ba0f1465b7e7eee68196eb51b1df8e01
Cr-Commit-Position: refs/heads/master@{#434946}