Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: components/suggestions/suggestions_service.cc

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)
Patch Set: undo JS changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service.cc
diff --git a/components/suggestions/suggestions_service.cc b/components/suggestions/suggestions_service.cc
index 16fe605c213fd7e814845910e94fea0515528a0e..47072e811b4356c16219bc1bccad12bbd57368ba 100644
--- a/components/suggestions/suggestions_service.cc
+++ b/components/suggestions/suggestions_service.cc
@@ -132,9 +132,6 @@ const char kAuthorizationHeaderFormat[] = "Authorization: Bearer %s";
const char kFaviconURL[] =
"https://s2.googleusercontent.com/s2/favicons?domain_url=%s&alt=s&sz=32";
-const char kPingURL[] =
- "https://www.google.com/chromesuggestions/click?q=%lld&cd=%d";
-
// The default expiry timeout is 168 hours.
const int64_t kDefaultExpiryUsec = 168 * base::Time::kMicrosecondsPerHour;
@@ -508,16 +505,6 @@ void SuggestionsService::PopulateExtraData(SuggestionsProfile* suggestions) {
if (!s->has_favicon_url() || s->favicon_url().empty()) {
s->set_favicon_url(base::StringPrintf(kFaviconURL, s->url().c_str()));
}
- if (!s->has_impression_url() || s->impression_url().empty()) {
- s->set_impression_url(
- base::StringPrintf(
- kPingURL, static_cast<long long>(suggestions->timestamp()), -1));
- }
-
- if (!s->has_click_url() || s->click_url().empty()) {
- s->set_click_url(base::StringPrintf(
- kPingURL, static_cast<long long>(suggestions->timestamp()), i));
- }
}
}
« no previous file with comments | « components/suggestions/proto/suggestions.proto ('k') | components/suggestions/suggestions_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698