Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6092)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)
Patch Set: undo JS changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/search/instant_types.h ('k') | components/suggestions/proto/suggestions.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 75e82dd0225dfc597b40a003c9bc0feb623edbd9..38ad0f9c08a872d8caf9f42ef29b1859feaeb6c0 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -183,16 +183,6 @@ v8::Local<v8::Object> GenerateMostVisitedItem(
obj->Set(v8::String::NewFromUtf8(isolate, "faviconUrl"),
UTF8ToV8String(isolate, mv_item.favicon.spec()));
}
- // If the suggestion has an impression url, we populate the element with it.
- if (!mv_item.impression_url.spec().empty()) {
- obj->Set(v8::String::NewFromUtf8(isolate, "impressionUrl"),
- UTF8ToV8String(isolate, mv_item.impression_url.spec()));
- }
- // If the suggestion has a click url, we populate the element with it.
- if (!mv_item.click_url.spec().empty()) {
- obj->Set(v8::String::NewFromUtf8(isolate, "pingUrl"),
- UTF8ToV8String(isolate, mv_item.click_url.spec()));
- }
if (IsIconNTPEnabled()) {
// Update website http://www.chromium.org/embeddedsearch when we make this
« no previous file with comments | « chrome/common/search/instant_types.h ('k') | components/suggestions/proto/suggestions.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698