Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2535803002: NTP: Remove impression/click pings (Closed)

Created:
4 years ago by Marc Treib
Modified:
4 years ago
Reviewers:
mastiz
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP: Remove impression/click pings BUG=646308 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0d2e39ccae180a2ae19b31b71b5af8db65077991 Cr-Commit-Position: refs/heads/master@{#436930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_single.js View 3 chunks +0 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Marc Treib
So, here's the (tiny) change that actually removes the impression/click pings. This isn't urgent at ...
4 years ago (2016-11-30 13:01:35 UTC) #3
mastiz
lgtm
4 years ago (2016-11-30 14:01:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535803002/1
4 years ago (2016-12-07 13:06:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 13:10:26 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-07 13:12:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d2e39ccae180a2ae19b31b71b5af8db65077991
Cr-Commit-Position: refs/heads/master@{#436930}

Powered by Google App Engine
This is Rietveld 408576698