chrome/common/search/instant_types.h - Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/search/instant_types.h

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)

Patch Set: undo JS changes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/search/instant_types.h

diff --git a/chrome/common/search/instant_types.h b/chrome/common/search/instant_types.h

index 8d78eab78cccfae2f613089ccd5e0d8c3d1fd084..7c7afa84f924270e9a4744a27f1dce1a8bce469b 100644

--- a/chrome/common/search/instant_types.h

+++ b/chrome/common/search/instant_types.h

@@ -141,10 +141,6 @@ struct InstantMostVisitedItem {

// The external URL of the favicon associated with this page.

GURL favicon;

- // The external URL that should be pinged when this item is suggested/clicked.

- GURL impression_url;

- GURL click_url;

// True if it's a server side suggestion.

// Otherwise, it's a client side suggestion.

bool is_server_side_suggestion;

« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »