Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1427)

Unified Diff: components/suggestions/suggestions_service_unittest.cc

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)
Patch Set: undo JS changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/suggestions/suggestions_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/suggestions/suggestions_service_unittest.cc
diff --git a/components/suggestions/suggestions_service_unittest.cc b/components/suggestions/suggestions_service_unittest.cc
index 4ba50733719bd47a8717696013a8e962b5b42633..2002d43bc3c1cc3f9f904ce70bfce3c7d64a8b4f 100644
--- a/components/suggestions/suggestions_service_unittest.cc
+++ b/components/suggestions/suggestions_service_unittest.cc
@@ -50,10 +50,6 @@ const char kTestUrl[] = "http://go.com";
const char kTestFaviconUrl[] =
"https://s2.googleusercontent.com/s2/favicons?domain_url="
"http://go.com&alt=s&sz=32";
-const char kTestImpressionUrl[] =
- "https://www.google.com/chromesuggestions/click?q=123&cd=-1";
-const char kTestClickUrl[] =
- "https://www.google.com/chromesuggestions/click?q=123&cd=0";
const char kBlacklistedUrl[] = "http://blacklist.com";
const char kBlacklistedUrlAlt[] = "http://blacklist-atl.com";
const int64_t kTestDefaultExpiry = 1402200000000000;
@@ -188,9 +184,6 @@ class SuggestionsServiceTest : public testing::Test {
EXPECT_EQ(kTestUrl, suggestions_profile.suggestions(0).url());
EXPECT_EQ(kTestFaviconUrl,
suggestions_profile.suggestions(0).favicon_url());
- EXPECT_EQ(kTestImpressionUrl,
- suggestions_profile.suggestions(0).impression_url());
- EXPECT_EQ(kTestClickUrl, suggestions_profile.suggestions(0).click_url());
}
int suggestions_data_callback_count_;
« no previous file with comments | « components/suggestions/suggestions_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698