components/suggestions/proto/suggestions.proto - Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/proto/suggestions.proto

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)

Patch Set: undo JS changes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/suggestions/proto/suggestions.proto

diff --git a/components/suggestions/proto/suggestions.proto b/components/suggestions/proto/suggestions.proto

index 12621e4b7eb7f6ba883a2421ed29a316395db4e2..27f5d141c33145bbaf1c9e3310555a7a1f97c8c6 100644

--- a/components/suggestions/proto/suggestions.proto

+++ b/components/suggestions/proto/suggestions.proto

@@ -52,10 +52,6 @@ message ChromeSuggestion {

// The timestamp (usec) at which this suggestion ceases to be valid.

optional int64 expiry_ts = 7;

- // URL that should be pinged back when the suggestion is shown/clicked.

- optional string impression_url = 13;

- optional string click_url = 14;

}

// A list of URLs that should be filtered from the SuggestionsProfile.